From: Christoph Hellwig <hch@lst.de>
Date: Tue, 22 Jun 2021 07:43:56 +0000 (+0200)
Subject: configfs: simplify configfs_release_bin_file
X-Git-Tag: v5.14-rc1~99^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c886fa3cf6ffbe13006053ceb27c93d41928de30;p=thirdparty%2Fkernel%2Flinux.git

configfs: simplify configfs_release_bin_file

Remove the clearing of various fields just before freeing the
buffer structure.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---

diff --git a/fs/configfs/file.c b/fs/configfs/file.c
index 3964183335135..2f63bf3a7325f 100644
--- a/fs/configfs/file.c
+++ b/fs/configfs/file.c
@@ -393,11 +393,8 @@ static int configfs_release_bin_file(struct inode *inode, struct file *file)
 {
 	struct configfs_buffer *buffer = file->private_data;
 
-	buffer->read_in_progress = false;
-
 	if (buffer->write_in_progress) {
 		struct configfs_fragment *frag = to_frag(file);
-		buffer->write_in_progress = false;
 
 		down_read(&frag->frag_sem);
 		if (!frag->frag_dead) {
@@ -410,9 +407,6 @@ static int configfs_release_bin_file(struct inode *inode, struct file *file)
 	}
 
 	vfree(buffer->bin_buffer);
-	buffer->bin_buffer = NULL;
-	buffer->bin_buffer_size = 0;
-	buffer->needs_read_fill = 1;
 
 	configfs_release(inode, file);
 	return 0;