From: John Ferlan <jferlan@redhat.com>
Date: Tue, 23 Jul 2019 12:14:50 +0000 (-0400)
Subject: tests: Avoid possible error in testExecRestart
X-Git-Tag: v5.6.0-rc1~106
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c8a4a02058af8788f1aeb32dec1d214aaeabf7a9;p=thirdparty%2Flibvirt.git

tests: Avoid possible error in testExecRestart

If the dup2 fails, then we aren't going to get the correct result.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
ACKed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c
index eae630a8f1..816bfe05d4 100644
--- a/tests/virnetdaemontest.c
+++ b/tests/virnetdaemontest.c
@@ -287,10 +287,13 @@ static int testExecRestart(const void *opaque)
      * fds 100->103 for something else, which is probably
      * fairly reasonable in general
      */
-    dup2(fdserver[0], 100);
-    dup2(fdserver[1], 101);
-    dup2(fdclient[0], 102);
-    dup2(fdclient[1], 103);
+    if (dup2(fdserver[0], 100) < 0 ||
+        dup2(fdserver[1], 101) < 0 ||
+        dup2(fdclient[0], 102) < 0 ||
+        dup2(fdclient[1], 103) < 0) {
+        virReportSystemError(errno, "%s", "dup2() failed");
+        goto cleanup;
+    }
 
     if (virAsprintf(&infile, "%s/virnetdaemondata/input-data-%s.json",
                     abs_srcdir, data->jsonfile) < 0)