From: Hugo Landau <hlandau@openssl.org>
Date: Wed, 30 Nov 2022 07:57:36 +0000 (+0000)
Subject: QUIC: Revise and add some TODO lines
X-Git-Tag: openssl-3.2.0-alpha1~1483
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c8b3fdc2e4833b065c0f7f0ff6ab771c6ff6b1a9;p=thirdparty%2Fopenssl.git

QUIC: Revise and add some TODO lines

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19703)
---

diff --git a/ssl/quic/quic_impl.c b/ssl/quic/quic_impl.c
index 6d78990cecf..aac427bc492 100644
--- a/ssl/quic/quic_impl.c
+++ b/ssl/quic/quic_impl.c
@@ -184,7 +184,7 @@ int ossl_quic_reset(SSL *s)
     if (!expect_quic_conn(qc))
         return 0;
 
-    /* Currently a no-op. */
+    /* TODO(QUIC); Currently a no-op. */
     return 1;
 }
 
@@ -196,7 +196,7 @@ int ossl_quic_clear(SSL *s)
     if (!expect_quic_conn(qc))
         return 0;
 
-    /* Currently a no-op. */
+    /* TODO(QUIC): Currently a no-op. */
     return 1;
 }
 
diff --git a/ssl/quic/quic_rx_depack.c b/ssl/quic/quic_rx_depack.c
index 8652a6ed6a0..da941dc1039 100644
--- a/ssl/quic/quic_rx_depack.c
+++ b/ssl/quic/quic_rx_depack.c
@@ -356,7 +356,6 @@ static int depack_do_frame_max_streams(PACKET *pkt,
     ackm_data->is_ack_eliciting = 1;
 
     if (max_streams > (((uint64_t)1) << 60)) {
-        /* TODO: Protocol violation (FRAME_ENCODING_ERROR) */
         ossl_quic_channel_raise_protocol_error(ch,
                                                QUIC_ERR_FRAME_ENCODING_ERROR,
                                                frame_type,
diff --git a/ssl/quic/quic_wire_pkt.c b/ssl/quic/quic_wire_pkt.c
index de3466daa21..e0180ec0604 100644
--- a/ssl/quic/quic_wire_pkt.c
+++ b/ssl/quic/quic_wire_pkt.c
@@ -836,6 +836,7 @@ int ossl_quic_calculate_retry_integrity_tag(OSSL_LIB_CTX *libctx,
         return 0;
 
     /* Create and initialise cipher context. */
+    /* TODO(QUIC): Cipher fetch caching. */
     if ((cipher = EVP_CIPHER_fetch(libctx, "AES-128-GCM", propq)) == NULL)
         goto err;