From: Michael Brown <mcb30@ipxe.org>
Date: Wed, 14 Jun 2017 16:40:05 +0000 (+0100)
Subject: [ecm] Display invalid MAC address strings in debug messages
X-Git-Tag: v1.20.1~194
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c8cb867d655227d779ce8ce9e392e853997b01dd;p=thirdparty%2Fipxe.git

[ecm] Display invalid MAC address strings in debug messages

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/drivers/net/ecm.c b/src/drivers/net/ecm.c
index f2d9161c1..847a45b85 100644
--- a/src/drivers/net/ecm.c
+++ b/src/drivers/net/ecm.c
@@ -101,13 +101,18 @@ int ecm_fetch_mac ( struct usb_device *usb,
 	}
 
 	/* Sanity check */
-	if ( len != ( ( int ) ( sizeof ( buf ) - 1 /* NUL */ ) ) )
+	if ( len != ( ( int ) ( sizeof ( buf ) - 1 /* NUL */ ) ) ) {
+		DBGC ( usb, "USB %s has invalid ECM MAC \"%s\"\n",
+		       usb->name, buf );
 		return -EINVAL;
+	}
 
 	/* Decode MAC address */
 	len = base16_decode ( buf, hw_addr, ETH_ALEN );
 	if ( len < 0 ) {
 		rc = len;
+		DBGC ( usb, "USB %s could not decode ECM MAC \"%s\": %s\n",
+		       usb->name, buf, strerror ( rc ) );
 		return rc;
 	}