From: Noel Power <noel.power@suse.com>
Date: Wed, 22 May 2019 12:03:36 +0000 (+0000)
Subject: s4/torture/smb2: cppcheck: Fix shiftTooManyBitsSigned error
X-Git-Tag: ldb-2.0.5~505
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c8cdc016b4c53109454f25ee675d083b556cc134;p=thirdparty%2Fsamba.git

s4/torture/smb2: cppcheck: Fix shiftTooManyBitsSigned error

Fixes

source4/torture/smb2/create.c:197: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck]
source4/torture/smb2/create.c:234: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck]
source4/torture/smb2/create.c:265: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source4/torture/smb2/create.c b/source4/torture/smb2/create.c
index 0ede6add54a..9b32062ab07 100644
--- a/source4/torture/smb2/create.c
+++ b/source4/torture/smb2/create.c
@@ -194,7 +194,7 @@ static bool test_create_gentest(struct torture_context *tctx, struct smb2_tree *
 	{
 		int i;
 		for (i=0;i<32;i++) {
-			io.in.create_options = 1<<i;
+			io.in.create_options = (uint32_t)1<<i;
 			if (io.in.create_options & NTCREATEX_OPTIONS_DELETE_ON_CLOSE) {
 				continue;
 			}
@@ -231,7 +231,7 @@ static bool test_create_gentest(struct torture_context *tctx, struct smb2_tree *
 	{
 		int i;
 		for (i=0;i<32;i++) {
-			io.in.desired_access = 1<<i;
+			io.in.desired_access = (uint32_t)1<<i;
 			status = smb2_create(tree, tctx, &io);
 			if (NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED) ||
 			    NT_STATUS_EQUAL(status, NT_STATUS_PRIVILEGE_NOT_HELD)) {
@@ -262,7 +262,7 @@ static bool test_create_gentest(struct torture_context *tctx, struct smb2_tree *
 	{
 		int i;
 		for (i=0;i<32;i++) {
-			io.in.file_attributes = 1<<i;
+			io.in.file_attributes = (uint32_t)1<<i;
 			if (io.in.file_attributes & FILE_ATTRIBUTE_ENCRYPTED) {
 				continue;
 			}