From: Jakub Kicinski Date: Mon, 19 Nov 2018 23:03:28 +0000 (-0800) Subject: tc: gred: remove unclear comment X-Git-Tag: v5.0.0~36^2~21^2~7 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c8f201e3d2329a29f8f309dba1d4948d4ead3c58;p=thirdparty%2Fiproute2.git tc: gred: remove unclear comment The comment about providing a proper message seems similar to the comment in the kernel which says: /* hack -- fix at some point with proper message This is how we indicate to tc that there is no VQ at this DP */ it's unclear what that message would be, and whether it's needed. Remove the confusing comment. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Signed-off-by: David Ahern --- diff --git a/tc/q_gred.c b/tc/q_gred.c index e63fac72a..80a9ccbbd 100644 --- a/tc/q_gred.c +++ b/tc/q_gred.c @@ -302,8 +302,6 @@ static int gred_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) return -1; } -/* Bad hack! should really return a proper message as shown above*/ - fprintf(f, "vqs %u default %u %s", sopt->DPs, sopt->def_DP,