From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 7 Mar 2022 04:07:48 +0000 (+1300)
Subject: tests/krb5: Simplify logic
X-Git-Tag: tevent-0.12.0~384
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c91af5f1a8b666cdd305165937bf28c551b88134;p=thirdparty%2Fsamba.git

tests/krb5: Simplify logic

This code can be made part of the previous 'else' branch.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Joseph Sutton <jsutton@samba.org>
Autobuild-Date(master): Fri Mar 18 00:11:25 UTC 2022 on sn-devel-184
---

diff --git a/python/samba/tests/krb5/raw_testcase.py b/python/samba/tests/krb5/raw_testcase.py
index 69c52b25761..bb3b7280515 100644
--- a/python/samba/tests/krb5/raw_testcase.py
+++ b/python/samba/tests/krb5/raw_testcase.py
@@ -2756,11 +2756,11 @@ class RawKerberosTest(TestCaseInTempDir):
             expect_pac_attrs_pac_request = kdc_exchange_dict[
                 'pac_request']
 
-        if expect_pac_attrs is None:
-            if self.expect_extra_pac_buffers:
-                expect_pac_attrs = expect_extra_pac_buffers
-            else:
-                require_strict.add(krb5pac.PAC_TYPE_ATTRIBUTES_INFO)
+            if expect_pac_attrs is None:
+                if self.expect_extra_pac_buffers:
+                    expect_pac_attrs = expect_extra_pac_buffers
+                else:
+                    require_strict.add(krb5pac.PAC_TYPE_ATTRIBUTES_INFO)
         if expect_pac_attrs:
             expected_types.append(krb5pac.PAC_TYPE_ATTRIBUTES_INFO)