From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 8 Jul 2018 19:21:05 +0000 (-0400)
Subject: allow help for commands with callbacks
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c92e5de35262eec647643c0beec601ec4bcd96c5;p=thirdparty%2Ffreeradius-server.git

allow help for commands with callbacks

which just prints the syntax for now
---

diff --git a/src/main/command.c b/src/main/command.c
index 1a6c7d8cc4d..b9b01f8b4cf 100644
--- a/src/main/command.c
+++ b/src/main/command.c
@@ -698,11 +698,6 @@ int fr_command_add(TALLOC_CTX *talloc_ctx, fr_cmd_t **head, char const *name, vo
 		return -1;
 	}
 
-	if (!table->func) {
-		fr_strerror_printf("Command tables MUST define a callback function.");
-		return -1;
-	}
-
 	start = head;
 	syntax_argv = NULL;
 
@@ -1504,7 +1499,12 @@ void fr_command_list(FILE *fp, int max_depth, fr_cmd_t *head, bool is_head)
 	if (max_depth > CMD_MAX_ARGV) max_depth = CMD_MAX_ARGV;
 
 	if (!is_head) {
-		if (!head->child) return;
+		if (!head->child) {
+			rad_assert(head->func != NULL);
+			// @todo - skip syntax_argv as necessary
+			fr_command_list_node(fp, head, 0, argv);
+			return;
+		}
 		head = head->child;
 	}