From: Noel Power <noel.power@suse.com>
Date: Wed, 15 Dec 2021 15:36:22 +0000 (+0000)
Subject: s3: smbd: In setup_close_full_information() the posix_open parameter is not needed... 
X-Git-Tag: tdb-1.4.6~281
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c94d919fd9c93f6d8987e2a0d6fa4ba066497d99;p=thirdparty%2Fsamba.git

s3: smbd: In setup_close_full_information() the posix_open parameter is not needed anymore.

Signed-off-by: Noel Power <npower@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/smbd/smb2_close.c b/source3/smbd/smb2_close.c
index 6059a1d503c..c218d12b668 100644
--- a/source3/smbd/smb2_close.c
+++ b/source3/smbd/smb2_close.c
@@ -153,7 +153,6 @@ static void smbd_smb2_request_close_done(struct tevent_req *subreq)
 
 static void setup_close_full_information(connection_struct *conn,
 				struct smb_filename *smb_fname,
-				bool posix_open,
 				struct timespec *out_creation_ts,
 				struct timespec *out_last_access_ts,
 				struct timespec *out_last_write_ts,
@@ -222,7 +221,6 @@ static NTSTATUS smbd_smb2_close(struct smbd_smb2_request *req,
 	uint64_t file_size = 0;
 	uint32_t dos_attrs = 0;
 	uint16_t flags = 0;
-	bool posix_open = false;
 
 	*out_creation_ts = (struct timespec){0, SAMBA_UTIME_OMIT};
 	*out_last_access_ts = (struct timespec){0, SAMBA_UTIME_OMIT};
@@ -242,7 +240,6 @@ static NTSTATUS smbd_smb2_close(struct smbd_smb2_request *req,
 		return NT_STATUS_NO_MEMORY;
 	}
 
-	posix_open = (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN);
 	smb_fname = cp_smb_filename(talloc_tos(), fsp->fsp_name);
 	if (smb_fname == NULL) {
 		return NT_STATUS_NO_MEMORY;
@@ -259,7 +256,6 @@ static NTSTATUS smbd_smb2_close(struct smbd_smb2_request *req,
 		 */
 		setup_close_full_information(conn,
 				smb_fname,
-				posix_open,
 				out_creation_ts,
 				out_last_access_ts,
 				out_last_write_ts,
@@ -280,7 +276,6 @@ static NTSTATUS smbd_smb2_close(struct smbd_smb2_request *req,
 	if (in_flags & SMB2_CLOSE_FLAGS_FULL_INFORMATION) {
 		setup_close_full_information(conn,
 				smb_fname,
-				posix_open,
 				out_creation_ts,
 				out_last_access_ts,
 				out_last_write_ts,