From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Fri, 16 Feb 2018 23:13:30 +0000 (-0500)
Subject: Remove erroneous skip message
X-Git-Tag: rel_1_2_3~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c94e4d888a87b82c062c5ecb9d97fca89bfdde12;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

Remove erroneous skip message

The logic here seems to try to say something different when
__backend__ is True but it produces a nonsensical message,
since __only_on__ doesn't tell us about the implementation
we are actually running.

Change-Id: I14e20cadcba975f8efe8fdefa439c8b8c480b3ed
---

diff --git a/lib/sqlalchemy/testing/plugin/plugin_base.py b/lib/sqlalchemy/testing/plugin/plugin_base.py
index 6b08ef49ab..1f74321a8b 100644
--- a/lib/sqlalchemy/testing/plugin/plugin_base.py
+++ b/lib/sqlalchemy/testing/plugin/plugin_base.py
@@ -554,24 +554,20 @@ def _do_skips(cls):
                 )
 
     if not all_configs:
-        if getattr(cls, '__backend__', False):
-            msg = "'%s' unsupported for implementation '%s'" % (
-                cls.__name__, cls.__only_on__)
-        else:
-            msg = "'%s' unsupported on any DB implementation %s%s" % (
-                cls.__name__,
-                ", ".join(
-                    "'%s(%s)+%s'" % (
-                        config_obj.db.name,
-                        ".".join(
-                            str(dig) for dig in
-                            config_obj.db.dialect.server_version_info),
-                        config_obj.db.driver
-                    )
-                  for config_obj in config.Config.all_configs()
-                ),
-                ", ".join(reasons)
-            )
+        msg = "'%s' unsupported on any DB implementation %s%s" % (
+            cls.__name__,
+            ", ".join(
+                "'%s(%s)+%s'" % (
+                    config_obj.db.name,
+                    ".".join(
+                        str(dig) for dig in
+                        config_obj.db.dialect.server_version_info),
+                    config_obj.db.driver
+                )
+              for config_obj in config.Config.all_configs()
+            ),
+            ", ".join(reasons)
+        )
         config.skip_test(msg)
     elif hasattr(cls, '__prefer_backends__'):
         non_preferred = set()