From: Victor Julien <vjulien@oisf.net>
Date: Wed, 13 Mar 2024 10:03:01 +0000 (+0100)
Subject: detect: add ticket id to var related todos
X-Git-Tag: suricata-8.0.0-beta1~1096
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c9631584434e33ed5fc20f19c66c5420a8d94f7a;p=thirdparty%2Fsuricata.git

detect: add ticket id to var related todos
---

diff --git a/src/detect-engine-register.h b/src/detect-engine-register.h
index 1a8a782825..04619cb01e 100644
--- a/src/detect-engine-register.h
+++ b/src/detect-engine-register.h
@@ -55,7 +55,7 @@ enum DetectKeywordId {
     /* end prefilter sort */
 
     /* values used in util-var.c go here, to avoid int overflows
-     * TODO update var logic to use a larger type. */
+     * TODO update var logic to use a larger type, see #6855. */
     DETECT_THRESHOLD,
     DETECT_FLOWBITS,
     DETECT_FLOWVAR,
diff --git a/src/util-var.h b/src/util-var.h
index fe3010097d..4732b46e47 100644
--- a/src/util-var.h
+++ b/src/util-var.h
@@ -46,6 +46,7 @@ enum VarTypes {
     VAR_TYPE_IPPAIR_VAR,
 };
 
+/** \todo see ticket #6855. The type field should be 16 bits. */
 typedef struct GenericVar_ {
     uint8_t type; /**< variable type, uses detection sm_type */
     uint8_t pad[3];