From: Matthew Jordan <mjordan@digium.com>
Date: Wed, 18 Sep 2013 17:17:13 +0000 (+0000)
Subject: Add a WARNING in bridge_softmix when a timing module isn't loaded
X-Git-Tag: 11.6.0-rc1~3^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c96b43b532be108bc523625350bf0c569e5596ba;p=thirdparty%2Fasterisk.git

Add a WARNING in bridge_softmix when a timing module isn't loaded

If bridge_softmix fails to be created because no timing source is present in
Asterisk, this will currently fail gracefully but with (most likely) a generic
error message by whatever module tried to create the softmix bridge. This
patch adds a more explicit warning so you can actually diagnose and fix the
problem.

Review: https://reviewboard.asterisk.org/r/2857/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@399353 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/bridges/bridge_softmix.c b/bridges/bridge_softmix.c
index 1a0b4fc181..bf9f014f54 100644
--- a/bridges/bridge_softmix.c
+++ b/bridges/bridge_softmix.c
@@ -313,6 +313,7 @@ static int softmix_bridge_create(struct ast_bridge *bridge)
 		return -1;
 	}
 	if (!(softmix_data->timer = ast_timer_open())) {
+		ast_log(AST_LOG_WARNING, "Failed to open timer for softmix bridge\n");
 		ao2_ref(softmix_data, -1);
 		return -1;
 	}