From: Rainer Jung <rjung@apache.org>
Date: Mon, 5 Aug 2019 18:52:42 +0000 (+0000)
Subject: Propose with essay.
X-Git-Tag: 2.4.41~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c9a38660f479de3a84ef7c08d3296aab833e433b;p=thirdparty%2Fapache%2Fhttpd.git

Propose with essay.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1864452 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/STATUS b/STATUS
index 1a76d951956..646e09561d6 100644
--- a/STATUS
+++ b/STATUS
@@ -166,6 +166,27 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
      2.4.x patch: svn merge -c 1864428 ^/httpd/httpd/trunk .
      +1: icing, covener
 
+  *) modules/filters: PR 63633: Fix broken compilation when using old GCC (<4.2.x).
+     The above line could be used as CHANGES item.
+     The GCC flag "-Wno-error=comment" introduced by r1855446
+     and r1850745 (backported in r1856931) is only known since GCC 4.2.
+     Since it gets set unconditionally, this breaks compilation with old GCC
+     even when not using maintainer mode.
+     Make the fix for maintainer mode more specific by using
+     a version dependent pragma in the relevant two C files
+     only switching off error status for comment warnings.
+     The original maintainer mode problem seems to happen only
+     on certain platforms (observed on MacOS) or clang, because I could
+     not reproduce with GCC on Linux and Solaris. So not fixing the maintainer
+     mode problem for ancient GCC before 4.6 might be OK. more important is not
+     to break normal compilation on old platforms.
+     trunk patch: http://svn.apache.org/r1864435
+                  http://svn.apache.org/r1864438
+                  http://svn.apache.org/r1864450
+                  http://svn.apache.org/r1864451
+     2.4.x patch: svn merge -c 1864435,1864438,1864450,1864451 ^/httpd/httpd/trunk .
+     +1: rjung
+
      
 PATCHES/ISSUES THAT ARE BEING WORKED
   [ New entries should be added at the START of the list ]
@@ -274,20 +295,6 @@ PATCHES/ISSUES THAT ARE BEING WORKED
              for internal users of this api; not sure if performance
              impact is significant from using malloc here.
 
-  *) modules/filters: PR 63633: Fix broken compilation when using old GCC (<4.2.x).
-     The GCC flag "-Wno-error=comment" introduced by r1855446
-     and r1850745 (backported in r1856931) are only known since GCC 4.2.
-     Since it gets set unconditionally, this breaks compilation with old GCC
-     even when not using maintainer mode.
-     Make the fix for maintainer mode more specific by using
-     a version dependent pragma in the relevant two C files
-     only switching off error status for comment warnings.
-     Still need some work due to feedback in the PR.
-     trunk patch: http://svn.apache.org/r1864435
-                  http://svn.apache.org/r1864438
-     2.4.x patch: svn merge -c 1864435,1864438 ^/httpd/httpd/trunk .
-     +1: 
-
 
 PATCHES/ISSUES THAT ARE STALLED