From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 29 Aug 2024 14:02:39 +0000 (-0400)
Subject: add dbuff macro which initializes output buffers
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c9a45ef12ccc35bb99c5fc78f11e474c9592de81;p=thirdparty%2Ffreeradius-server.git

add dbuff macro which initializes output buffers

and use it to quiet the compiler.
---

diff --git a/src/lib/server/tmpl_tokenize.c b/src/lib/server/tmpl_tokenize.c
index 092c1f2872..1de1861792 100644
--- a/src/lib/server/tmpl_tokenize.c
+++ b/src/lib/server/tmpl_tokenize.c
@@ -2740,7 +2740,7 @@ static ssize_t tmpl_afrom_ether_substr(TALLOC_CTX *ctx, tmpl_t **out, fr_sbuff_t
 	fr_value_box_t		*vb;
 	fr_sbuff_parse_error_t	err;
 
-	fr_dbuff_init(&dbuff, buff, sizeof(buff));
+	FR_DBUFF_INIT(&dbuff, buff, sizeof(buff));
 
 	fr_base16_decode(&err, &dbuff, &our_in, true);
 	if (err != FR_SBUFF_PARSE_OK) return 0;
diff --git a/src/lib/util/dbuff.h b/src/lib/util/dbuff.h
index a23e948525..eaacc6d06b 100644
--- a/src/lib/util/dbuff.h
+++ b/src/lib/util/dbuff.h
@@ -374,6 +374,11 @@ _fr_dbuff_init(_out, \
 DIAG_ON(maybe-uninitialized)
 #endif
 
+#define FR_DBUFF_INIT(_out, _start, _len_or_end) do { \
+	fr_dbuff_init(_out, _start, _len_or_end); \
+	*(unsigned char *) _start = '\0'; \
+  } while (0)
+
 size_t	_fr_dbuff_extend_talloc(fr_dbuff_t *dbuff, size_t extension);
 
 int	fr_dbuff_trim_talloc(fr_dbuff_t *dbuff, size_t len);