From: John Ferlan <jferlan@redhat.com>
Date: Mon, 4 May 2015 16:00:40 +0000 (-0400)
Subject: xen: Resolve Coverity FORWARD_NULL
X-Git-Tag: v1.2.16-rc1~123
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c9a8e5944034a92df52de93a58a4f05f5b76e6c6;p=thirdparty%2Flibvirt.git

xen: Resolve Coverity FORWARD_NULL

Coverity found that xenXMConfigCacheAddFile has an error path in which
no error message and a -1 was not returned which could have resulted in
a NULL dereference in a VIR_DEBUG statement and of course an erroneous
0 value returned!
---

diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c
index 64752dfa63..59b1cd4afa 100644
--- a/src/xen/xm_internal.c
+++ b/src/xen/xm_internal.c
@@ -279,6 +279,9 @@ xenXMConfigCacheAddFile(virConnectPtr conn, const char *filename)
             virDomainDefFree(entry->def);
             VIR_FREE(entry->filename);
             VIR_FREE(entry);
+            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                           _("xenXMConfigCacheRefresh: virHashAddEntry name"));
+            return -1;
         }
     }
     VIR_DEBUG("Added config %s %s", entry->def->name, filename);