From: Tom Tromey <tom@tromey.com>
Date: Sun, 18 Jan 2026 17:09:19 +0000 (-0700)
Subject: Remove lookup_transparent_type lang hook
X-Git-Tag: binutils-2_46~135
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c9c9d89158a60cc0da8aec39ce09913c0e775f87;p=thirdparty%2Fbinutils-gdb.git

Remove lookup_transparent_type lang hook

C++ was the only user of the lookup_transparent_type lang hook, so it
can be removed entirely.  basic_lookup_transparent_type and its helper
function are renamed as appropriate.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
---

diff --git a/gdb/language.h b/gdb/language.h
index 50a4c026784..1a6420af74e 100644
--- a/gdb/language.h
+++ b/gdb/language.h
@@ -346,14 +346,6 @@ struct language_defn
   virtual void language_arch_info (struct gdbarch *,
 				   struct language_arch_info *) const = 0;
 
-  /* Find the definition of the type with the given name.  */
-
-  virtual struct type *lookup_transparent_type (const char *name,
-						domain_search_flags flags) const
-  {
-    return basic_lookup_transparent_type (name, flags);
-  }
-
   /* Find all symbols in the current program space matching NAME in
      DOMAIN, according to this language's rules.
 
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 63505a94d41..35e380980b5 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -2622,22 +2622,14 @@ symbol::matches (domain_search_flags flags) const
   return search_flags_matches (flags, m_domain);
 }
 
-/* See symtab.h.  */
-
-struct type *
-lookup_transparent_type (const char *name, domain_search_flags flags)
-{
-  return current_language->lookup_transparent_type (name, flags);
-}
-
-/* A helper for basic_lookup_transparent_type that interfaces with the
+/* A helper for lookup_transparent_type that interfaces with the
    "quick" symbol table functions.  */
 
 static struct type *
-basic_lookup_transparent_type_quick (struct objfile *objfile,
-				     enum block_enum block_index,
-				     domain_search_flags flags,
-				     const lookup_name_info &name)
+lookup_transparent_type_quick (struct objfile *objfile,
+			       enum block_enum block_index,
+			       domain_search_flags flags,
+			       const lookup_name_info &name)
 {
   struct compunit_symtab *cust;
   const struct blockvector *bv;
@@ -2658,14 +2650,10 @@ basic_lookup_transparent_type_quick (struct objfile *objfile,
   return sym->type ();
 }
 
-/* The standard implementation of lookup_transparent_type.  This code
-   was modeled on lookup_symbol -- the parts not relevant to looking
-   up types were just left out.  In particular it's assumed here that
-   types are available in STRUCT_DOMAIN and only in file-static or
-   global blocks.  */
+/* See symtab.h.  */
 
 struct type *
-basic_lookup_transparent_type (const char *name, domain_search_flags flags)
+lookup_transparent_type (const char *name, domain_search_flags flags)
 {
   struct type *t;
 
@@ -2674,8 +2662,8 @@ basic_lookup_transparent_type (const char *name, domain_search_flags flags)
   /* Search all the global symbols.  */
   for (objfile &objfile : current_program_space->objfiles ())
     {
-      t = basic_lookup_transparent_type_quick (&objfile, GLOBAL_BLOCK,
-					       flags, lookup_name);
+      t = lookup_transparent_type_quick (&objfile, GLOBAL_BLOCK,
+					 flags, lookup_name);
       if (t)
 	return t;
     }
@@ -2684,8 +2672,8 @@ basic_lookup_transparent_type (const char *name, domain_search_flags flags)
      but more useful than an error.  */
   for (objfile &objfile : current_program_space->objfiles ())
     {
-      t = basic_lookup_transparent_type_quick (&objfile, STATIC_BLOCK,
-					       flags, lookup_name);
+      t = lookup_transparent_type_quick (&objfile, STATIC_BLOCK,
+					 flags, lookup_name);
       if (t)
 	return t;
     }
diff --git a/gdb/symtab.h b/gdb/symtab.h
index bd305e5259c..6a1320aabad 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -2320,9 +2320,6 @@ extern void reread_symbols (int from_tty);
 extern struct type *lookup_transparent_type
     (const char *name, domain_search_flags flags = SEARCH_STRUCT_DOMAIN);
 
-extern struct type *basic_lookup_transparent_type
-     (const char *name, domain_search_flags flags = SEARCH_STRUCT_DOMAIN);
-
 /* Macro for name of symbol to indicate a file compiled with gcc.  */
 #ifndef GCC_COMPILED_FLAG_SYMBOL
 #define GCC_COMPILED_FLAG_SYMBOL "gcc_compiled."