From: Jan Engelhardt <jengelh@medozas.de>
Date: Sat, 4 Apr 2009 16:43:15 +0000 (+0200)
Subject: CLASSIFY: document non-standard interpretation behavior
X-Git-Tag: v1.4.3.2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=c9ccba543b52cb443f110670420967ac6a41c302;p=thirdparty%2Fiptables.git

CLASSIFY: document non-standard interpretation behavior

Most other extensions use strtoul (by means of xtables_strtoui)
and would abide by the standard convention of hex/octal prefixes
0x/0, and decimal otherwise, but CLASSIFY is an exception.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---

diff --git a/extensions/libxt_CLASSIFY.c b/extensions/libxt_CLASSIFY.c
index 119922d0..7db2e4cd 100644
--- a/extensions/libxt_CLASSIFY.c
+++ b/extensions/libxt_CLASSIFY.c
@@ -15,7 +15,7 @@ CLASSIFY_help(void)
 {
 	printf(
 "CLASSIFY target options:\n"
-"  --set-class [MAJOR:MINOR]    Set skb->priority value\n");
+"--set-class MAJOR:MINOR    Set skb->priority value (always hexadecimal!)\n");
 }
 
 static const struct option CLASSIFY_opts[] = {
diff --git a/extensions/libxt_CLASSIFY.man b/extensions/libxt_CLASSIFY.man
index 578883e3..0270fd18 100644
--- a/extensions/libxt_CLASSIFY.man
+++ b/extensions/libxt_CLASSIFY.man
@@ -1,4 +1,5 @@
 This module allows you to set the skb\->priority value (and thus classify the packet into a specific CBQ class).
 .TP
 \fB\-\-set\-class\fP \fImajor\fP\fB:\fP\fIminor\fP
-Set the major and minor class value.
+Set the major and minor class value. The values are always interpreted as
+hexadecimal even if no 0x prefix is given.