From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sun, 10 Dec 2017 12:45:25 +0000 (+0000)
Subject: Emit error if the encoder fails
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ca0c365bd457dbd537877e110d2671844df939bc;p=thirdparty%2Ffreeradius-server.git

Emit error if the encoder fails
---

diff --git a/src/modules/rlm_eap/types/rlm_eap_aka/rlm_eap_aka.c b/src/modules/rlm_eap/types/rlm_eap_aka/rlm_eap_aka.c
index bf6641f4d17..c923572443d 100644
--- a/src/modules/rlm_eap/types/rlm_eap_aka/rlm_eap_aka.c
+++ b/src/modules/rlm_eap/types/rlm_eap_aka/rlm_eap_aka.c
@@ -57,6 +57,10 @@ static int eap_aka_compose(eap_session_t *eap_session)
 	return fr_sim_encode(eap_session->request, dict_aka_root, FR_EAP_AKA,
 			     eap_session->request->reply->vps, eap_session->this_round->request,
 			     &eap_aka_session->keys);
+	if (ret < 0) {
+		RPEDEBUG("Failed encoding EAP-AKA data");
+		return -1;
+	}
 }
 
 /** Send an EAP-AKA identity request to the supplicant
diff --git a/src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c b/src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c
index 6eeb4d931d3..b53c28ffddd 100644
--- a/src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c
+++ b/src/modules/rlm_eap/types/rlm_eap_sim/rlm_eap_sim.c
@@ -71,7 +71,10 @@ static int eap_sim_compose(eap_session_t *eap_session)
 	fr_pair_cursor_first(&to_encode);
 	fr_pair_cursor_free(&to_encode);
 
-	if (ret < 0) return -1;
+	if (ret < 0) {
+		RPEDEBUG("Failed encoding EAP-SIM data");
+		return -1;
+	}
 	return 0;
 }