From: Douglas Bagnall Date: Mon, 27 Nov 2023 21:46:40 +0000 (+1300) Subject: libcli/security: remove redundant claim SID size check X-Git-Tag: talloc-2.4.2~529 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ca572691622ca30097d172fe2843dca34eb3764f;p=thirdparty%2Fsamba.git libcli/security: remove redundant claim SID size check blob_string_sid_to_sid() immediately checks the size is within 5-191, so the 1-10000 just gives you a different message in chircumstances you'll never see. Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/libcli/security/claims-conversions.c b/libcli/security/claims-conversions.c index 935c5eedfd8..85206511883 100644 --- a/libcli/security/claims-conversions.c +++ b/libcli/security/claims-conversions.c @@ -163,13 +163,6 @@ static bool claim_v1_sid_to_ace_sid( v = claim->values[offset].sid_value; - if (v->length == 0 || v->length > CONDITIONAL_ACE_MAX_LENGTH) { - DBG_WARNING("claim has SID string of unexpected length %zu, " - "(expected range 1 - %u)\n", - v->length, CONDITIONAL_ACE_MAX_LENGTH); - return false; - } - ok = blob_string_sid_to_sid(v, &result->data.sid.sid); if (! ok) { DBG_WARNING("claim has invalid SID string of length %zu.\n",