From: Jakub Jelinek <jakub@redhat.com>
Date: Fri, 31 Jul 2026 07:05:50 +0000 (+0200)
Subject: gimplify: Allow declarations in recalculate_side_effects [PR126497]
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ca867fd9d5ace4ede8289dba9ae731e554bde618;p=thirdparty%2Fgcc.git

gimplify: Allow declarations in recalculate_side_effects [PR126497]

The following testcase ICEs, because we decide to fold a comparison
into just one of its operands, we call recalculate_side_effects on that
and ICE on the assertion that it isn't called on anything unexpected
(here PARM_DECL).
Already some time ago we had to add an exception for SSA_NAME for the
same reason.
The tcc_declaration case is slightly different, TREE_SIDE_EFFECTS is
sometimes present on those if they are TREE_THIS_VOLATILE, but it is
something the FE should take care of when creating those decls, not
a business of the gimplifier.

2026-07-31  Jakub Jelinek  <jakub@redhat.com>

	PR middle-end/126497
	* gimplify.cc (recalculate_side_effects): Return for
	tcc_declaration.

	* gcc.dg/bitint-141.c: New test.

Reviewed-by: Andrea Pinski <andrew.pinski@oss.qualcomm.com>
---

diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc
index 333e0a3f3a9..0f8bf533ba7 100644
--- a/gcc/gimplify.cc
+++ b/gcc/gimplify.cc
@@ -3361,6 +3361,13 @@ recalculate_side_effects (tree t)
       /* No side-effects.  */
       return;
 
+    case tcc_declaration:
+      /* These can have side-effects if TREE_THIS_VOLATILE,
+	 but those should be set elsewhere, not in
+	 recalculate_side_effects.  Can be triggered e.g. if
+	 a comparison is folded into one of its operands.  */
+      return;
+
     default:
       if (code == SSA_NAME)
 	/* No side-effects.  */
diff --git a/gcc/testsuite/gcc.dg/bitint-141.c b/gcc/testsuite/gcc.dg/bitint-141.c
new file mode 100644
index 00000000000..f3f22bbb0bf
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/bitint-141.c
@@ -0,0 +1,19 @@
+/* PR middle-end/126497 */
+/* { dg-do compile { target bitint } } */
+/* { dg-options "-std=c23" } */
+
+typedef unsigned _BitInt (1) U;
+
+U
+foo (U a)
+{
+  U t = a >= 1uwb;
+  return t;
+}
+
+U
+bar (U a)
+{
+  U t = a == 1uwb;
+  return t;
+}