From: Kevin Harwell <kharwell@digium.com>
Date: Mon, 19 Oct 2020 20:31:14 +0000 (-0500)
Subject: res_pjsip, res_pjsip_session: initialize local variables
X-Git-Tag: 13.38.0-rc1~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ca8f0b1d21b9c46ebfaf980ba9bf35d6b5339b8a;p=thirdparty%2Fasterisk.git

res_pjsip, res_pjsip_session: initialize local variables

This patch initializes a couple of local variables to some default values.
Interestingly, in the 'pj_status_t dlg_status' case the value not being
initialized caused memory to grow, and not be recovered, in the off nominal
path (at least on my machine).

Change-Id: I22ee65e1e1bff8efacea8a167c6c8428898523f7
---

diff --git a/res/res_pjsip/pjsip_transport_management.c b/res/res_pjsip/pjsip_transport_management.c
index ceac889e9e..b57ce75f82 100644
--- a/res/res_pjsip/pjsip_transport_management.c
+++ b/res/res_pjsip/pjsip_transport_management.c
@@ -78,7 +78,7 @@ static void keepalive_transport_send_keepalive(struct monitored_transport *monit
 static void *keepalive_transport_thread(void *data)
 {
 	struct ao2_container *transports;
-	pj_thread_desc desc;
+	pj_thread_desc desc = { 0 };
 	pj_thread_t *thread;
 
 	if (pj_thread_register("Asterisk Keepalive Thread", desc, &thread) != PJ_SUCCESS) {
diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c
index eb0db18830..c93be19ffd 100644
--- a/res/res_pjsip_session.c
+++ b/res/res_pjsip_session.c
@@ -2092,7 +2092,7 @@ static pjsip_inv_session *pre_session_setup(pjsip_rx_data *rdata, const struct a
 	pjsip_dialog *dlg;
 	pjsip_inv_session *inv_session;
 	unsigned int options = endpoint->extensions.flags;
-	pj_status_t dlg_status;
+	pj_status_t dlg_status = PJ_EUNKNOWN;
 
 	if (pjsip_inv_verify_request(rdata, &options, NULL, NULL, ast_sip_get_pjsip_endpoint(), &tdata) != PJ_SUCCESS) {
 		if (tdata) {