From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Wed, 2 May 2018 21:59:13 +0000 (+1200)
Subject: s4/param/provision py_dom_sid_FromSid: avoid python memleak
X-Git-Tag: ldb-1.6.1~284
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=ca93b1e15a1c0606fe7e2d149af30cc0168fdb7b;p=thirdparty%2Fsamba.git

s4/param/provision py_dom_sid_FromSid: avoid python memleak

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Noel Power <npower@samba.org>

Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue Jan 29 16:54:48 CET 2019 on sn-devel-144
---

diff --git a/source4/param/provision.c b/source4/param/provision.c
index 153850667b1..ee84cd021e1 100644
--- a/source4/param/provision.c
+++ b/source4/param/provision.c
@@ -199,13 +199,15 @@ static PyObject *py_dom_sid_FromSid(struct dom_sid *sid)
 	PyObject *mod_security, *dom_sid_Type;
 
 	mod_security = PyImport_ImportModule("samba.dcerpc.security");
-	if (mod_security == NULL)
+	if (mod_security == NULL) {
 		return NULL;
-
+	}
 	dom_sid_Type = PyObject_GetAttrString(mod_security, "dom_sid");
-	if (dom_sid_Type == NULL)
+	if (dom_sid_Type == NULL) {
+		Py_DECREF(mod_security);
 		return NULL;
-
+	}
+	Py_DECREF(mod_security);
 	return pytalloc_reference((PyTypeObject *)dom_sid_Type, sid);
 }