From: Evan You <yyx990803@gmail.com>
Date: Thu, 30 May 2019 13:31:53 +0000 (+0800)
Subject: refactor: tweak watch getter logic
X-Git-Tag: v3.0.0-alpha.0~969
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=caad39c3536127793ea9bc1c75eb5bf5c2b8ff21;p=thirdparty%2Fvuejs%2Fcore.git

refactor: tweak watch getter logic
---

diff --git a/packages/runtime-core/src/reactivity.ts b/packages/runtime-core/src/reactivity.ts
index fa102b2f1c..30976be5c0 100644
--- a/packages/runtime-core/src/reactivity.ts
+++ b/packages/runtime-core/src/reactivity.ts
@@ -33,6 +33,8 @@ import { currentInstance } from './component'
 import { queueJob, queuePostFlushCb } from './scheduler'
 import { EMPTY_OBJ, isObject, isArray } from '@vue/shared'
 
+// record effects created during a component's setup() so that they can be
+// stopped when the component unmounts
 function recordEffect(effect: ReactiveEffect) {
   if (currentInstance) {
     ;(currentInstance.effects || (currentInstance.effects = [])).push(effect)
@@ -71,11 +73,8 @@ export function watch<T>(
         ? queueJob
         : queuePostFlushCb
 
-  const traverseIfDeep = (getter: Function) =>
-    options.deep ? () => traverse(getter()) : getter
-  const getter = isValue(source)
-    ? traverseIfDeep(() => source.value)
-    : traverseIfDeep(source)
+  const baseGetter = isValue(source) ? () => source.value : source
+  const getter = options.deep ? () => traverse(baseGetter()) : baseGetter
 
   let oldValue: any
   const applyCb = cb