From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 31 Oct 2022 20:39:25 +0000 (+0200)
Subject: dsync: ns_mailbox_try_alloc() - Don't set errstr_r when mailbox wasn't found
X-Git-Tag: 2.4.0~3464
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cab6f1cae0e4a41130ad4b045423ae179521f27c;p=thirdparty%2Fdovecot%2Fcore.git

dsync: ns_mailbox_try_alloc() - Don't set errstr_r when mailbox wasn't found

It's unnecessary and confusing, since the callers can't really use it
anyway.
---

diff --git a/src/doveadm/dsync/dsync-brain-mailbox.c b/src/doveadm/dsync/dsync-brain-mailbox.c
index a9fd3827d3..965fb514f6 100644
--- a/src/doveadm/dsync/dsync-brain-mailbox.c
+++ b/src/doveadm/dsync/dsync-brain-mailbox.c
@@ -37,9 +37,6 @@ ns_mailbox_try_alloc(struct dsync_brain *brain, struct mail_namespace *ns,
 	}
 	if (existence != MAILBOX_EXISTENCE_SELECT) {
 		mailbox_free(&box);
-		*errstr_r = existence == MAILBOX_EXISTENCE_NONE ?
-			"Mailbox was already deleted" :
-			"Mailbox is no longer selectable";
 		return 0;
 	}
 	*box_r = box;