From: Daniel Stenberg <daniel@haxx.se>
Date: Fri, 10 May 2024 08:24:15 +0000 (+0200)
Subject: tool_getparam: remove two redundant conditions
X-Git-Tag: curl-8_8_0~97
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cabbb9b2a5a5dfec0709ceb19a731af2bf012cf2;p=thirdparty%2Fcurl.git

tool_getparam: remove two redundant conditions

When getstr() does not return error, it returns a valid pointer.

Spotted by CodeSonar

Closes #13576
---

diff --git a/src/tool_getparam.c b/src/tool_getparam.c
index f56981a743..7c265c9afe 100644
--- a/src/tool_getparam.c
+++ b/src/tool_getparam.c
@@ -894,8 +894,7 @@ static ParameterError data_urlencode(struct GlobalConfig *global,
     err = getstr(&postdata, p, ALLOW_BLANK);
     if(err)
       goto error;
-    if(postdata)
-      size = strlen(postdata);
+    size = strlen(postdata);
   }
 
   if(!postdata) {
@@ -1124,8 +1123,7 @@ static ParameterError set_data(cmdline_t cmd,
     err = getstr(&postdata, nextarg, ALLOW_BLANK);
     if(err)
       return err;
-    if(postdata)
-      size = strlen(postdata);
+    size = strlen(postdata);
   }
   if(cmd == C_JSON)
     config->jsoned = TRUE;