From: Nikolai Barybin <nikolai.barybin@virtuozzo.com>
Date: Thu, 3 Jul 2025 10:19:07 +0000 (+0300)
Subject: qemu: qapi: fix potential SIGSEGV in virQEMUQAPISchemaTraverseObject()
X-Git-Tag: v11.6.0-rc1~106
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cad407c8620e117b2826c7e662b9f04a8142641f;p=thirdparty%2Flibvirt.git

qemu: qapi: fix potential SIGSEGV in virQEMUQAPISchemaTraverseObject()

We need to check obj ptr before passing it to
virJSONValueObjectHasKey(). If it's NULL it will fail with SIGSEGV.

Signed-off-by: Nikolai Barybin <nikolai.barybin@virtuozzo.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/qemu/qemu_qapi.c b/src/qemu/qemu_qapi.c
index 184c0a965f..a2fef55019 100644
--- a/src/qemu/qemu_qapi.c
+++ b/src/qemu/qemu_qapi.c
@@ -180,7 +180,7 @@ virQEMUQAPISchemaTraverseObject(virJSONValue *cur,
     } else {
         obj = virQEMUQAPISchemaObjectGet("members", query, "name", cur);
 
-        if (modifier == '*' &&
+        if (modifier == '*' && obj &&
             !virJSONValueObjectHasKey(obj, "default"))
             return 0;
     }