From: Julian Seward <jseward@acm.org>
Date: Sat, 2 Feb 2019 13:20:49 +0000 (+0100)
Subject: Enable -Wformat-signedness, if the compiler supports it.
X-Git-Tag: VALGRIND_3_15_0~77
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cadbb5d441acf1925f4707d8012db77c02766cc2;p=thirdparty%2Fvalgrind.git

Enable -Wformat-signedness, if the compiler supports it.
---

diff --git a/configure.ac b/configure.ac
index a02a76b2ac..b885bd91bf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2095,18 +2095,11 @@ AC_GCC_WARNING_SUBST_NO([unused-function], [FLAG_W_NO_UNUSED_FUNCTION])
 AC_GCC_WARNING_SUBST_NO([static-local-in-inline], [FLAG_W_NO_STATIC_LOCAL_IN_INLINE])
 AC_GCC_WARNING_SUBST_NO([mismatched-new-delete], [FLAG_W_NO_MISMATCHED_NEW_DELETE])
 AC_GCC_WARNING_SUBST_NO([infinite-recursion], [FLAG_W_NO_INFINITE_RECURSION])
+
 AC_GCC_WARNING_SUBST([write-strings], [FLAG_W_WRITE_STRINGS])
 AC_GCC_WARNING_SUBST([empty-body], [FLAG_W_EMPTY_BODY])
 AC_GCC_WARNING_SUBST([format], [FLAG_W_FORMAT])
-# Disabled for now until all platforms are clean
-format_checking_enabled=no
-#format_checking_enabled=yes
-if test "$format_checking_enabled" = "yes"; then
-   AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS])
-else
-   dumy_assignment_to_avoid_syntax_errors=1
-   AC_SUBST([FLAG_W_FORMAT_SIGNEDNESS], [])
-fi
+AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS])
 AC_GCC_WARNING_SUBST([cast-qual], [FLAG_W_CAST_QUAL])
 AC_GCC_WARNING_SUBST([old-style-declaration], [FLAG_W_OLD_STYLE_DECLARATION])
 AC_GCC_WARNING_SUBST([ignored-qualifiers], [FLAG_W_IGNORED_QUALIFIERS])