From: Matthijs Mekking <matje@NLnetLabs.nl>
Date: Tue, 6 Mar 2012 09:01:07 +0000 (+0000)
Subject: update code documentation svn:NO TEST
X-Git-Tag: release-1.6.13rc1~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=caeb1466585c19d44bcd0c267daa3c9ff2f96318;p=thirdparty%2Fldns.git

update code documentation svn:NO TEST
---

diff --git a/dnssec_sign.c b/dnssec_sign.c
index ec7b8d7a..88878bad 100644
--- a/dnssec_sign.c
+++ b/dnssec_sign.c
@@ -1278,7 +1278,8 @@ ldns_dnssec_zone_sign_nsec3_flg_mkmap(ldns_dnssec_zone *zone,
 									 salt_length,
 									 salt);
 				/* always set bit 7 of the flags to zero, according to
-				 * rfc5155 section 11 */
+				 * rfc5155 section 11. The bits are counted from right to left,
+				 * so bit 7 in rfc5155 is bit 0 in ldns */
 				ldns_set_bit(ldns_rdf_data(ldns_rr_rdf(nsec3param, 1)), 0, 0);
 				result = ldns_dnssec_zone_add_rr(zone, nsec3param);
 				if (result != LDNS_STATUS_OK) {
diff --git a/util.c b/util.c
index f49a30d1..a7ab9608 100644
--- a/util.c
+++ b/util.c
@@ -107,6 +107,10 @@ ldns_get_bit_r(uint8_t bits[], size_t index)
 void
 ldns_set_bit(uint8_t *byte, int bit_nr, bool value)
 {
+	/*
+	 * The bits are counted from right to left, so bit #0 is the
+	 * right most bit.
+	 */
 	if (bit_nr >= 0 && bit_nr < 8) {
 		if (value) {
 			*byte = *byte | (0x01 << bit_nr);