From: Emeric Brun <ebrun@haproxy.com>
Date: Mon, 14 Jun 2021 08:02:18 +0000 (+0200)
Subject: BUG/MAJOR: resolvers: segfault using server template without SRV RECORDs
X-Git-Tag: v2.5-dev1~135
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=caef19e0c7594b00aa341d8984a33ddd0f15113f;p=thirdparty%2Fhaproxy.git

BUG/MAJOR: resolvers: segfault using server template without SRV RECORDs

This patch fix the issue adding a test in srvrq before registering
the server on it during server template init.

This was a regression due to commit :
3406766d57fc11478d54a6fa2d048cbfe4524a4e

This should be backported with this previous commit (until 2.0)
---

diff --git a/src/server.c b/src/server.c
index 30ee13530b..57b3feecb6 100644
--- a/src/server.c
+++ b/src/server.c
@@ -2306,7 +2306,8 @@ static int _srv_parse_tmpl_init(struct server *srv, struct proxy *px)
 		}
 #endif
 		/* append to list of servers available to receive an hostname */
-		LIST_APPEND(&newsrv->srvrq->attached_servers, &newsrv->srv_rec_item);
+		if (newsrv->srvrq)
+			LIST_APPEND(&newsrv->srvrq->attached_servers, &newsrv->srv_rec_item);
 
 		/* Set this new server ID. */
 		_srv_parse_set_id_from_prefix(newsrv, srv->tmpl_info.prefix, i);