From: Matija Skala <mskala@gmx.com>
Date: Tue, 25 Apr 2017 12:44:29 +0000 (+0200)
Subject: fix parenthesis in pager.c (#5798)
X-Git-Tag: v234~287
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=caf222104afe2d12f3a188a6bfee3a35f2d04fc6;p=thirdparty%2Fsystemd.git

fix parenthesis in pager.c (#5798)

- result of dup2 should be compared against 0
- making parenthesis around comparisons just to be sure
---

diff --git a/src/shared/pager.c b/src/shared/pager.c
index 2501a53c199..22d7603ec69 100644
--- a/src/shared/pager.c
+++ b/src/shared/pager.c
@@ -176,11 +176,11 @@ void pager_close(void) {
 
         /* Inform pager that we are done */
         (void) fflush(stdout);
-        if (stdout_redirected && (stored_stdout < 0 || dup2(stored_stdout, STDOUT_FILENO)) < 0)
+        if (stdout_redirected && ((stored_stdout < 0) || (dup2(stored_stdout, STDOUT_FILENO) < 0)))
                 (void) close(STDOUT_FILENO);
         stored_stdout = safe_close(stored_stdout);
         (void) fflush(stderr);
-        if (stderr_redirected && (stored_stderr < 0 || dup2(stored_stderr, STDERR_FILENO)) < 0)
+        if (stderr_redirected && ((stored_stderr < 0) || (dup2(stored_stderr, STDERR_FILENO) < 0)))
                 (void) close(STDERR_FILENO);
         stored_stderr = safe_close(stored_stderr);
         stdout_redirected = stderr_redirected = false;