From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 18 Feb 2015 13:02:39 +0000 (+0100)
Subject: conf: Automatically use NUMA memory size in case NUMA is enabled
X-Git-Tag: v1.2.14-rc1~148
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=caf88a3c888b104a787fa8d37e956d48f607ef72;p=thirdparty%2Flibvirt.git

conf: Automatically use NUMA memory size in case NUMA is enabled

Use the NUMA total instead of the configured size both in XML and for
uses in the code once NUMA is enabled for a domain.

One test case change is necessary as the rounding of the individual cell
sizes was not matching the rounding of the total size.
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d27d42b920..4ecb58c90f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6985,6 +6985,12 @@ virDomainParseMemoryLimit(const char *xpath,
 unsigned long long
 virDomainDefGetMemoryInitial(virDomainDefPtr def)
 {
+    unsigned long long ret;
+
+    /* return NUMA memory size total in case numa is enabled */
+    if ((ret = virDomainNumaGetMemorySize(def->numa)) > 0)
+        return ret;
+
     return def->mem.max_balloon;
 }
 
diff --git a/tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.args b/tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.args
index 513d657646..5dd7fcd2ef 100644
--- a/tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.args
+++ b/tests/qemuxml2argvdata/qemuxml2argv-numatune-memnode.args
@@ -1,5 +1,5 @@
 LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \
-/usr/bin/kvm -S -M pc -m 24104 -smp 32 \
+/usr/bin/kvm -S -M pc -m 24105 -smp 32 \
 -object memory-backend-ram,id=ram-node0,size=20971520,host-nodes=3,\
 policy=preferred \
 -numa node,nodeid=0,cpus=0,memdev=ram-node0 \