From: Michael Brown <mcb30@ipxe.org>
Date: Mon, 7 Dec 2020 13:48:35 +0000 (+0000)
Subject: [interface] Ignore any attempts to plug in the null interface
X-Git-Tag: v1.21.1~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb0ba2f8253bc4ed3b301928c4a84d6ca1e7593b;p=thirdparty%2Fipxe.git

[interface] Ignore any attempts to plug in the null interface

Allow intf_plug() and intf_plug_plug() to be called safely on
interfaces that may be the null interface.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/core/interface.c b/src/core/interface.c
index 402aa4541..05e7e4777 100644
--- a/src/core/interface.c
+++ b/src/core/interface.c
@@ -81,9 +81,14 @@ struct interface null_intf = INTF_INIT ( null_intf_desc );
  * interface is updated to point to the new destination interface.
  */
 void intf_plug ( struct interface *intf, struct interface *dest ) {
+
+	if ( intf == &null_intf )
+		return;
+
 	DBGC ( INTF_COL ( intf ),
 	       "INTF " INTF_INTF_FMT " replug to " INTF_FMT "\n",
 	       INTF_INTF_DBG ( intf, intf->dest ), INTF_DBG ( dest ) );
+
 	intf_get ( dest );
 	intf_put ( intf->dest );
 	intf->dest = dest;