From: Eric Leblond <eric@regit.org>
Date: Fri, 25 Nov 2011 17:40:34 +0000 (+0100)
Subject: TLS parser: modify OCTETSTRING
X-Git-Tag: suricata-1.3beta1~88
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb1a75fc9e8d162eaa4777de313cd005c0742b01;p=thirdparty%2Fsuricata.git

TLS parser: modify OCTETSTRING

This patch does on over allocation of 1 for the OCTETSTRING
to be able to add a 0 at the end. This will then
allow us to use the string in printf.
---

diff --git a/src/util-decode-der.c b/src/util-decode-der.c
index 8f7974b267..2f530b84a7 100644
--- a/src/util-decode-der.c
+++ b/src/util-decode-der.c
@@ -505,12 +505,15 @@ static Asn1Generic * DecodeAsn1DerOctetString(const unsigned char *buffer, uint3
         return NULL;
     a->type = ASN1_OCTETSTRING;
     a->strlen = length;
-    a->str = SCMalloc(length);
+    /* Add one to the octet string for the 0. This will then
+     * allow us to use the string in printf */
+    a->str = SCMalloc(length + 1);
     if (a->str == NULL) {
         SCFree(a);
         return NULL;
     }
     memcpy(a->str, (const char*)d_ptr, length);
+    a->str[length] = 0;
 
     d_ptr += length;