From: Dan Carpenter Date: Sat, 29 Nov 2025 14:51:05 +0000 (+0300) Subject: remoteproc: qcom: q6v5: Fix NULL vs IS_ERR() bug in q6v5_alloc_memory_region() X-Git-Tag: v6.19-rc1~82^2~3 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb200e41ed61c571f9b7fe9fbeb5dd8976e80c60;p=thirdparty%2Fkernel%2Flinux.git remoteproc: qcom: q6v5: Fix NULL vs IS_ERR() bug in q6v5_alloc_memory_region() The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functions for "memory-region"") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/674b32a78563282adeaf3cdf941314a0b8181026.1764427595.git.dan.carpenter@linaro.org Signed-off-by: Bjorn Andersson --- diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c index ca748e3bcc7f9..d96af0e0f6659 100644 --- a/drivers/remoteproc/qcom_q6v5_wcss.c +++ b/drivers/remoteproc/qcom_q6v5_wcss.c @@ -887,9 +887,9 @@ static int q6v5_alloc_memory_region(struct q6v5_wcss *wcss) wcss->mem_reloc = res.start; wcss->mem_size = resource_size(&res); wcss->mem_region = devm_ioremap_resource_wc(dev, &res); - if (!wcss->mem_region) { + if (IS_ERR(wcss->mem_region)) { dev_err(dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(wcss->mem_region); } return 0;