From: Matthew Jordan <mjordan@digium.com>
Date: Mon, 11 Feb 2013 15:03:40 +0000 (+0000)
Subject: Fix crash in res_xmpp when deleting pubsub node from CLI
X-Git-Tag: 11.4.0-rc1~74
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb3dd0278160594294b8f1cb5b402f787a15cfea;p=thirdparty%2Fasterisk.git

Fix crash in res_xmpp when deleting pubsub node from CLI

An error existed in res_xmpp where it would attempt to delete attributes from
a node that itself was also deleted. Per the iksemel documentation, attributes
added using iks_insert are copied to the parent node's stack, and will be
reclaimed when that node is itself destroyed.

(closes issue ASTERISK-20982)
Reported by: marcelloceschia
patches:
  delete-node-fix.diff uploaded by marcelloceschia (License 6036)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@381159 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/res/res_xmpp.c b/res/res_xmpp.c
index 24612ba122..a651dd51fa 100644
--- a/res/res_xmpp.c
+++ b/res/res_xmpp.c
@@ -1083,8 +1083,6 @@ static void xmpp_pubsub_delete_node(struct ast_xmpp_client *client, const char *
 	iks_insert_attrib(delete, "node", node_name);
 	ast_xmpp_client_send(client, request);
 
-	iks_delete(delete);
-	iks_delete(pubsub);
 	iks_delete(request);
 }