From: mmj <none@none>
Date: Sun, 6 Jun 2004 21:57:40 +0000 (+1000)
Subject: Prep for 0.6.0 and small debug info removal etc.
X-Git-Tag: RELEASE_1_0_0~144
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb3eec3e80c500a7185ac6402ce4d98355d8d4fe;p=thirdparty%2Fmlmmj.git

Prep for 0.6.0 and small debug info removal etc.
---

diff --git a/ChangeLog b/ChangeLog
index 30e98988..5eeedb72 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,5 @@
+0.6.0
+ o Add several unlinks. No need to litter queue/ with useless files
  o Don't use moderation/queue for outgoing, just use queue/
  o Christoph Thiel pointed out that listaddress and moderators belong in
    control/ so move them there
diff --git a/README b/README
index 06786a22..be9b0eb6 100644
--- a/README
+++ b/README
@@ -1,4 +1,4 @@
-README mlmmj-0.5.2					May 29th 2004
+README mlmmj-0.6.0					Jun 6th 2004
 
 This is an attempt at implementing a mailing list manager with the same
 functionality as the brilliant ezmlm, but with a decent license and mail server
@@ -59,9 +59,13 @@ To use mlmmj, do the following:
 
    NOTE: Don't forget newaliases.
 
+4) Start mlmmj-maintd (remember full path when starting it!) or add it to
+   crontab with -F switch. Note that mlmmj-maintd is still work in progress,
+   but except bouncehandling everything should be there.
+
 That's it! You might want to go through the next steps too.
 
-4) Subscribe some people
+5) Subscribe some people
 
    mlmmj-sub -L /var/spool/mlmmj/mlmmj-test/ -a joe@domain.tld
 
@@ -71,30 +75,30 @@ That's it! You might want to go through the next steps too.
    directory and files in there, if you don't perform all list actions as the
    user that writes mail.
 
-5) If you want custom headers like X-Mailinglist, Reply-To: etc. just add a
+6) If you want custom headers like X-Mailinglist, Reply-To: etc. just add a
    file called 'customheaders' in the list control/ directory like this:
    $ cat /var/spool/mlmmj/mlmmj-test/control/customheaders
    X-Mailinglist: mlmmj-test
    Reply-To: mlmmj-test@domain.tld
 
-6) If you want every mail to have something like:
+7) If you want every mail to have something like:
    -- 
    To unsubscribe send a mail to coollist+unsubscribe@lists.domain.net
 
    Just add what you want to a file named "footer" in the same dir as
    "customheader" (listdir/control/).
 
-7) For having a moderated list, simply create a file called 'moderated' in the
+8) For having a moderated list, simply create a file called 'moderated' in the
    control/ directory. Moderators are added to a file called 'moderators' in
    the listdir, just like subscribers are in the subscribers file.
 
-8) Have a look at the file TUNABLES for runtime configurable things.
+9) Have a look at the file TUNABLES for runtime configurable things.
 
 Tunables in include/mlmmj.h:
-If you want to use something else than localhost for your maildelivery you have
-to change RELAYHOST.
-If you want to spawn more than 3 smtp connections to your relayhost, change
-MAX_CONNECTIONS to the desired value.
+ · If you want to use something else than localhost for your maildelivery you have
+   to change RELAYHOST.
+ · There's some time intervals for how mlmmj-maintd operates. I've choosen
+   non-strict defaults, so depending on your BOFH rate you might want to tweak.
 
 Have a fun!
 
diff --git a/TODO b/TODO
index 76b5c73d..59438761 100644
--- a/TODO
+++ b/TODO
@@ -7,4 +7,4 @@
  o mlmmj-maintenance (in progress)
 
 An ever ongoing TODO is we need someone to run it all through valgrind or
-similar and plug all memory leaks etc.
+similar and plug all memory and fd leaks etc.
diff --git a/UPGRADE b/UPGRADE
index 4abf4129..c805e33c 100644
--- a/UPGRADE
+++ b/UPGRADE
@@ -10,6 +10,8 @@ This applies to everyone using mlmmj > 0.5.2:
 
   · moderation/queue
 
+ Start mlmmj-maintd
+
 This applies to everyone using mlmmj > 0.5.1:
 ---------------------------------------------
 
diff --git a/VERSION b/VERSION
index f05cdec4..a918a2aa 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-0.6.0-RC1
+0.6.0
diff --git a/src/mlmmj-send.c b/src/mlmmj-send.c
index 0ccfc0cf..762bf127 100644
--- a/src/mlmmj-send.c
+++ b/src/mlmmj-send.c
@@ -303,7 +303,7 @@ int send_mail_many(int sockfd, const char *from, const char *replyto,
 	for(next = cur = start; next < start + st.st_size; next++) {
 		if(*next == '\n' || next == start + st.st_size - 1) {
 			len = next - cur;
-			if(next == start + st.st_size - 1)
+			if(next == start + st.st_size - 1 && *next != '\n')
 				len++;
 			addr = malloc(len + 1);
 			strncpy(addr, cur, len);
@@ -349,8 +349,7 @@ int send_mail_many(int sockfd, const char *from, const char *replyto,
 				do {
 					/* Dirty hack to add newline. */
 					len = strlen(addr);
-					addr[len] = '\n';
-					if(writen(addrfd, addr, len+1) < 0)
+					if(writen(addrfd, addr, len) < 0)
 						log_error(LOG_ARGS,
 							"Could not add [%s] "
 							"to requeue address "