From: JINMEI Tatuya <jinmei@isc.org>
Date: Fri, 31 Aug 2012 00:57:53 +0000 (+0900)
Subject: [2098] try to improve in-method comments for isSameKind()
X-Git-Tag: trac2351_base~91^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb4c5b31b47ea1062cb74077ff5788f192d60eac;p=thirdparty%2Fkea.git

[2098] try to improve in-method comments for isSameKind()
---

diff --git a/src/lib/datasrc/memory/treenode_rrset.cc b/src/lib/datasrc/memory/treenode_rrset.cc
index 6fc6b66682..11898a3f26 100644
--- a/src/lib/datasrc/memory/treenode_rrset.cc
+++ b/src/lib/datasrc/memory/treenode_rrset.cc
@@ -339,11 +339,12 @@ TreeNodeRRset::isSameKind(const AbstractRRset& abs_other) const {
         if (rdataset_ != other->rdataset_) {
             return (false);
         }
-        // Same for the owner name (note: in practice this method would be
-        // called for rrsets at different nodes, so we check that condition
-        // first).  Note also that based on the basic assumption of the
-        // ZoneTree, if the nodes are different their RR classes must be
-        // different.
+        // Same for the owner name.  Comparing the nodes also detect
+        // the case where RR classes are different (see the method description
+        // of the header for details).
+        // hasSameRealName() is a bit more complicated and we expect the
+        // two nodes are often different here in practice, so we check that
+        // condition first.
         if (node_ != other->node_ || !hasSameRealName(*other)) {
             return (false);
         }