From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 4 Jul 2023 10:32:34 +0000 (+0200)
Subject: s3:winbindd: call reset_cm_connection_on_error() in wb_cache_query_user_list()
X-Git-Tag: talloc-2.4.1~88
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb59fd43bbf758e4bad774cfc19ef87b157052c2;p=thirdparty%2Fsamba.git

s3:winbindd: call reset_cm_connection_on_error() in wb_cache_query_user_list()

This is mostly for consistency, every remote call should call
reset_cm_connection_on_error(). Note this is more than
a simple invalidate_cm_connection() as it may set
domain->conn.netlogon_force_reauth = true.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15413

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c
index 7cb3e60943b..d23b3415825 100644
--- a/source3/winbindd/winbindd_cache.c
+++ b/source3/winbindd/winbindd_cache.c
@@ -1508,6 +1508,7 @@ do_query:
 			DBG_NOTICE("query_user_list: returned 0x%08x, "
 				  "retrying\n", NT_STATUS_V(status));
 		}
+		reset_cm_connection_on_error(domain, NULL, status);
 		if (NT_STATUS_EQUAL(status, NT_STATUS_UNSUCCESSFUL)) {
 			DBG_NOTICE("query_user_list: flushing "
 				  "connection cache\n");