From: Phil Sutter Date: Sat, 5 May 2018 12:44:26 +0000 (+0200) Subject: proto: Fix wrong token in proto_icmp6 X-Git-Tag: v0.8.5~16 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb5f6e846667f69a508559790a3ea84820f86842;p=thirdparty%2Fnftables.git proto: Fix wrong token in proto_icmp6 'token' value of ICMP6HDR_MTU field must be 'mtu', not 'packet-too-big'. This went unnoticed because rule delinearization for icmp/icmpv6 payload expressions is problematic anyway in that different fields point to the same offset and therefore are indistinguishable. In this case, an expression like e.g. 'icmpv6 mtu 1500' will be printed later as 'icmpv6 parameter-problem 1500'. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- diff --git a/src/proto.c b/src/proto.c index 8cf29d20..ed011efa 100644 --- a/src/proto.c +++ b/src/proto.c @@ -689,7 +689,7 @@ const struct proto_desc proto_icmp6 = { [ICMP6HDR_CODE] = ICMP6HDR_FIELD("code", icmp6_code), [ICMP6HDR_CHECKSUM] = ICMP6HDR_FIELD("checksum", icmp6_cksum), [ICMP6HDR_PPTR] = ICMP6HDR_FIELD("parameter-problem", icmp6_pptr), - [ICMP6HDR_MTU] = ICMP6HDR_FIELD("packet-too-big", icmp6_mtu), + [ICMP6HDR_MTU] = ICMP6HDR_FIELD("mtu", icmp6_mtu), [ICMP6HDR_ID] = ICMP6HDR_FIELD("id", icmp6_id), [ICMP6HDR_SEQ] = ICMP6HDR_FIELD("sequence", icmp6_seq), [ICMP6HDR_MAXDELAY] = ICMP6HDR_FIELD("max-delay", icmp6_maxdelay),