From: Victor Julien <vjulien@oisf.net>
Date: Wed, 26 Apr 2023 05:41:16 +0000 (+0200)
Subject: github-ci: add padding check to scan-build
X-Git-Tag: suricata-7.0.0-rc2~325
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb66a1e636282bfb622a056358ae697c3e6800d4;p=thirdparty%2Fsuricata.git

github-ci: add padding check to scan-build
---

diff --git a/.github/workflows/scan-build.yml b/.github/workflows/scan-build.yml
index a56b1634a1..54cf741c6b 100644
--- a/.github/workflows/scan-build.yml
+++ b/.github/workflows/scan-build.yml
@@ -66,6 +66,8 @@ jobs:
         env:
           CC: clang-16
       # exclude libhtp from the analysis
+      # disable security.insecureAPI.DeprecatedOrUnsafeBufferHandling explicitly as
+      # this will require significant effort to address.
       - run: |
           scan-build-16 --status-bugs --exclude libhtp/ \
                 -enable-checker valist.Uninitialized \
@@ -83,9 +85,9 @@ jobs:
                 -enable-checker nullability.NullableReturnedFromNonnull \
                 -enable-checker nullability.NullablePassedToNonnull \
                 -enable-checker nullability.NullableDereferenced \
+                -enable-checker optin.performance.Padding \
                 \
                 -disable-checker security.insecureAPI.DeprecatedOrUnsafeBufferHandling \
-                -disable-checker optin.performance.Padding \
                 \
                 make
         env: