From: Eric Leblond <eric@regit.org>
Date: Thu, 11 Feb 2016 10:44:12 +0000 (+0100)
Subject: xff: fix address overwrite in forward case
X-Git-Tag: suricata-3.0.1RC1~104
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb66db5ef2a843d1ef8817c983fde5e443cef063;p=thirdparty%2Fsuricata.git

xff: fix address overwrite in forward case
---

diff --git a/src/app-layer-htp-xff.c b/src/app-layer-htp-xff.c
index 96c6de487f..edc5168eea 100644
--- a/src/app-layer-htp-xff.c
+++ b/src/app-layer-htp-xff.c
@@ -160,7 +160,7 @@ int HttpXFFGetIPFromTx(const Packet *p, uint64_t tx_id, HttpXFFCfg *xff_cfg,
             /** Get the first IP address from the chain */
             p_xff = memchr(xff_chain, ',', bstr_len(h_xff->value));
             if (p_xff != NULL) {
-                xff_chain[bstr_len(h_xff->value) - (p_xff - xff_chain)]=0;
+                *p_xff = 0;
             }
             p_xff = xff_chain;
         }