From: Philip Lorenz Date: Mon, 28 Jul 2025 09:59:29 +0000 (+0200) Subject: package: Drop var-undefined QA check X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb69d7eba80215f9f8b74dafe40ca2289fa294aa;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git package: Drop var-undefined QA check The variables checked for are mandatory in all cases so a QA check does not seem to be the right choice for this. Additionally, the code never called `exit_if_errors` so the reported QA issue didn't actually fail the task. Signed-off-by: Philip Lorenz Signed-off-by: Mathieu Dubois-Briand Signed-off-by: Richard Purdie --- diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 4ef664b3ce..fed8163c3e 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -35,7 +35,7 @@ CHECKLAYER_REQUIRED_TESTS = "\ packages-list patch-fuzz patch-status perllocalpod perm-config perm-line perm-link recipe-naming \ pkgconfig pkgvarcheck pkgv-undefined pn-overrides shebang-size src-uri-bad symlink-to-sysroot \ unhandled-features-check unknown-configure-option unlisted-pkg-lics uppercase-pn useless-rpaths \ - var-undefined virtual-slash xorg-driver-abi" + virtual-slash xorg-driver-abi" # Elect whether a given type of error is a warning or error, they may # have been set by other files. diff --git a/meta/classes-global/package.bbclass b/meta/classes-global/package.bbclass index 9be1d6a5b1..d7ff333f20 100644 --- a/meta/classes-global/package.bbclass +++ b/meta/classes-global/package.bbclass @@ -494,8 +494,7 @@ python do_package () { pn = d.getVar('PN') if not workdir or not outdir or not dest or not dvar or not pn: - msg = "WORKDIR, DEPLOY_DIR, D, PN and PKGD all must be defined, unable to package" - oe.qa.handle_error("var-undefined", msg, d) + bb.fatal("WORKDIR, DEPLOY_DIR, D, PN and PKGD all must be defined, unable to package") return bb.build.exec_func("package_setup_pkgv", d)