From: Ján Tomko <jtomko@redhat.com>
Date: Sun, 20 Oct 2019 10:37:05 +0000 (+0200)
Subject: util: fix check for iscsi initiator copy
X-Git-Tag: v5.9.0-rc1~141
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb756a99143a0d5979e3fe0c15b2b87adae4837d;p=thirdparty%2Flibvirt.git

util: fix check for iscsi initiator copy

virStorageSourceInitiatorCopy propagates the return
value from VIR_STRDUP, which returns 1 on a successful
copy.

Only error out on < 0, not non-zero values.

Fixes: 9ea3fdc6e90a96e3d7d7aeb9867e8f0a3992b7c6

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index e04cc413a4..acf26721e7 100644
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -2331,7 +2331,7 @@ virStorageSourceCopy(const virStorageSource *src,
         !(def->pr = virStoragePRDefCopy(src->pr)))
         return NULL;
 
-    if (virStorageSourceInitiatorCopy(&def->initiator, &src->initiator))
+    if (virStorageSourceInitiatorCopy(&def->initiator, &src->initiator) < 0)
         return NULL;
 
     if (backingChain && src->backingStore) {