From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Fri, 24 Feb 2012 22:28:33 +0000 (-0700)
Subject: clientReplyContext::setReplyToStoreEntry() must lock the entry
X-Git-Tag: BumpSslServerFirst.take05~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cb9060beb21ebded32738d824bb857c07d5fa436;p=thirdparty%2Fsquid.git

clientReplyContext::setReplyToStoreEntry() must lock the entry

because clientReplyContext destructors always unlocks it via
removeClientStoreReference().
---

diff --git a/src/client_side_reply.cc b/src/client_side_reply.cc
index f335ae251e..f4021fea72 100644
--- a/src/client_side_reply.cc
+++ b/src/client_side_reply.cc
@@ -135,6 +135,7 @@ void clientReplyContext::setReplyToError(const HttpRequestMethod& method, ErrorS
 
 void clientReplyContext::setReplyToStoreEntry(StoreEntry *entry)
 {
+    entry->lock(); // removeClientStoreReference() unlocks
     sc = storeClientListAdd(entry, this);
 #if USE_DELAY_POOLS
     sc->setDelayId(DelayId::DelayClient(http));