From: Volker Lendecke <vl@samba.org>
Date: Mon, 28 Nov 2022 10:25:32 +0000 (+0100)
Subject: lib: Use talloc_asprintf_addbuf() in rdn_name_add()
X-Git-Tag: talloc-2.4.0~249
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cbcf7f0d21b146b52bf472a3627b7ea8cd3d0b80;p=thirdparty%2Fsamba.git

lib: Use talloc_asprintf_addbuf() in rdn_name_add()

Add implicit NULL checks

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/lib/ldb/modules/rdn_name.c b/lib/ldb/modules/rdn_name.c
index d90b8a52347..a49ce621c1b 100644
--- a/lib/ldb/modules/rdn_name.c
+++ b/lib/ldb/modules/rdn_name.c
@@ -180,8 +180,8 @@ static int rdn_name_add(struct ldb_module *module, struct ldb_request *req)
 				ldb_dn_get_linearized(msg->dn), rdn_name,
 				(int)rdn_val.length, (const char *)rdn_val.data);
 			for (i = 0; i < attribute->num_values; i++) {
-				rdn_errstring = talloc_asprintf_append(
-					rdn_errstring, " (%.*s)",
+				talloc_asprintf_addbuf(
+					&rdn_errstring, " (%.*s)",
 					(int)attribute->values[i].length,
 					(const char *)attribute->values[i].data);
 			}