From: Shweta Sodani <ssodani@redhat.com>
Date: Tue, 21 Apr 2026 12:03:18 +0000 (+0530)
Subject: s3:winbind: add bounds check for dom_sid_idx
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cbdab70651e6060b69dbddc44d4a9e8248b826d8;p=thirdparty%2Fsamba.git

s3:winbind: add bounds check for dom_sid_idx

Add SMB_ASSERT to verify dom_sid_idx stays within the
dom_sids/dom_xids array bounds in wb_xids2sids_dom_done().

Signed-off-by: Shweta Sodani <ssodani@redhat.com>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source3/winbindd/wb_xids2sids.c b/source3/winbindd/wb_xids2sids.c
index 0384740d17d..88e6e442905 100644
--- a/source3/winbindd/wb_xids2sids.c
+++ b/source3/winbindd/wb_xids2sids.c
@@ -192,6 +192,7 @@ static void wb_xids2sids_dom_done(struct tevent_req *subreq)
 			continue;
 		}
 
+		SMB_ASSERT(dom_sid_idx < state->num_dom_xids);
 		sid_copy(&state->all_sids[i], &state->dom_sids[dom_sid_idx]);
 		*id = state->dom_xids[dom_sid_idx];
 		D_DEBUG("%zu: XID %"PRIu32" mapped to SID %s.\n",