From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Fri, 23 Jan 2026 19:19:22 +0000 (+0100) Subject: [3.13] gh-144027: Fix documentation for ignorechars in base64.a85decode() (GH-144028... X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cbfebb1bc5d6a658dbb2784e5a3a5f3fcd4bea30;p=thirdparty%2FPython%2Fcpython.git [3.13] gh-144027: Fix documentation for ignorechars in base64.a85decode() (GH-144028) (GH-144193) It does not support an ASCII string. Also add more tests. (cherry picked from commit 25a10b60b04ab2fa802409dc6f211cf2ca028a0a) Co-authored-by: Serhiy Storchaka --- diff --git a/Doc/library/base64.rst b/Doc/library/base64.rst index 529a72424438..1c2c57448cee 100644 --- a/Doc/library/base64.rst +++ b/Doc/library/base64.rst @@ -239,8 +239,7 @@ Refer to the documentation of the individual functions for more information. *adobe* controls whether the input sequence is in Adobe Ascii85 format (i.e. is framed with <~ and ~>). - *ignorechars* should be a :term:`bytes-like object` or ASCII string - containing characters to ignore + *ignorechars* should be a byte string containing characters to ignore from the input. This should only contain whitespace characters, and by default contains all whitespace characters in ASCII. diff --git a/Lib/test/test_base64.py b/Lib/test/test_base64.py index 1d5bb6695d2b..368d359264ef 100644 --- a/Lib/test/test_base64.py +++ b/Lib/test/test_base64.py @@ -777,6 +777,19 @@ class BaseXYTestCase(unittest.TestCase): self.assertRaises(ValueError, base64.a85decode, b'aaaay', foldspaces=True) + self.assertEqual(base64.a85decode(b"a b\nc", ignorechars=b" \n"), + b'\xc9\x89') + with self.assertRaises(ValueError): + base64.a85decode(b"a b\nc", ignorechars=b"") + with self.assertRaises(ValueError): + base64.a85decode(b"a b\nc", ignorechars=b" ") + with self.assertRaises(ValueError): + base64.a85decode(b"a b\nc", ignorechars=b"\n") + with self.assertRaises(TypeError): + base64.a85decode(b"a b\nc", ignorechars=" \n") + with self.assertRaises(TypeError): + base64.a85decode(b"a b\nc", ignorechars=None) + def test_b85decode_errors(self): illegal = list(range(33)) + \ list(b'"\',./:[\\]') + \