From: Jim Fehlig <jfehlig@suse.com>
Date: Thu, 14 Jun 2012 17:20:17 +0000 (-0600)
Subject: Check for errors when parsing bridge interface XML
X-Git-Tag: v0.9.13-rc1~63
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cc004a664750e84a234d01ae4a5d774f7f980307;p=thirdparty%2Flibvirt.git

Check for errors when parsing bridge interface XML

The return status of virInterfaceDefParseBridge() was not being
checked, potentially resulting in the creation of a broken
interface.
---

diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c
index 5601d3b87f..0aeb1e2d1a 100644
--- a/src/conf/interface_conf.c
+++ b/src/conf/interface_conf.c
@@ -769,7 +769,8 @@ virInterfaceDefParseXML(xmlXPathContextPtr ctxt, int parentIfType) {
             }
             def->data.bridge.delay = virXMLPropString(bridge, "delay");
             ctxt->node = bridge;
-            virInterfaceDefParseBridge(def, ctxt);
+            if (virInterfaceDefParseBridge(def, ctxt) < 0)
+                goto error;
             break;
         }
         case VIR_INTERFACE_TYPE_BOND: {