From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 7 Aug 2024 11:14:57 +0000 (+0100)
Subject: rlm_rest no longer opens connectios at server start
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cc0ecd20f62f1f8d6ecb9ae40d2a7fdba6d4fd4a;p=thirdparty%2Ffreeradius-server.git

rlm_rest no longer opens connectios at server start

Since the move to async
---

diff --git a/raddb/mods-available/rest b/raddb/mods-available/rest
index a252763bb6d..f3f9f266930 100644
--- a/raddb/mods-available/rest
+++ b/raddb/mods-available/rest
@@ -144,13 +144,7 @@ rest {
 	}
 
 	#
-	#  connect_uri:: It will open a connection to the server specified in `connect_uri`
-	#  to populate the connection cache, ready for the first request.
-	#
-	#  If you wish to disable this pre-caching and reachability check,
-	#  comment out the configuration item below.
-	#
-	#  WARNING: The server will not start if the server specified is unreachable.
+	#  connect_uri:: Base URI used to avoid repetition in sections below.
 	#
 	connect_uri = "http://127.0.0.1:9090/"
 
diff --git a/src/modules/rlm_rest/rest.c b/src/modules/rlm_rest/rest.c
index 7030641a94a..5c9c465279d 100644
--- a/src/modules/rlm_rest/rest.c
+++ b/src/modules/rlm_rest/rest.c
@@ -249,11 +249,6 @@ static int _mod_conn_free(fr_curl_io_request_t *randle)
  * which hold the context data required for generating requests and parsing
  * responses.
  *
- * If instance->connect_uri is not NULL libcurl will attempt to open a
- * TCP socket to the server specified in the URI. This is done so that when the
- * socket is first used, there will already be a cached TCP connection to the
- * REST server associated with the curl handle.
- *
  * @see fr_pool_init
  * @see fr_pool_connection_create_t
  * @see connection.c