From: Michal Privoznik Date: Thu, 21 Nov 2013 15:34:40 +0000 (+0100) Subject: virDomainReboot: Document that migration might be unsafe X-Git-Tag: v1.2.0-rc1~26 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=cc38d68dc1d580fd9acc648e11057b1903ddb247;p=thirdparty%2Flibvirt.git virDomainReboot: Document that migration might be unsafe https://bugzilla.redhat.com/show_bug.cgi?id=744967 If a domain is rebooting and a migrate API is called meanwhile we would have to transfer the fakeReboot attribute to the destination in order to prevent domain doing plain shutdown over there. We shouldn't try to do anything clever about it other than documenting this as a known limitation. Signed-off-by: Michal Privoznik --- diff --git a/src/libvirt.c b/src/libvirt.c index 9355d33c41..eff44eb72b 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3434,6 +3434,11 @@ error: * To use guest agent (VIR_DOMAIN_REBOOT_GUEST_AGENT) the domain XML * must have configured. * + * Due to implementation limitations in some drivers (the qemu driver, + * for instance) it is not advised to migrate or save a guest that is + * rebooting as a result of this API. Migrating such a guest can lead + * to a plain shutdown on the destination. + * * Returns 0 in case of success and -1 in case of failure. */ int